-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: defork cloud-provider-azure for 1.29 #7207
chore: defork cloud-provider-azure for 1.29 #7207
Conversation
/label tide/merge-method-squash |
@comtalyst: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (subject to passing tests); also wondering about cloud-provider-azure version
@@ -55,15 +55,18 @@ require ( | |||
k8s.io/kubernetes v1.29.6 | |||
k8s.io/legacy-cloud-providers v0.0.0 | |||
k8s.io/utils v0.0.0-20231127182322-b307cd553661 | |||
sigs.k8s.io/cloud-provider-azure v1.29.0 | |||
sigs.k8s.io/cloud-provider-azure v1.29.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest is 1.29.9, do we plan to bump it separately from this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(discussed offline) separately
/approve |
/assign @feiskyer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: comtalyst, feiskyer, tallaxes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
107499c
into
kubernetes:cluster-autoscaler-release-1.29
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Backport of #6947
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Should be identical to the original PR.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: