add fallback option for session related scenarios #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
adikul30
force-pushed
the
topic/aditya/fallback-session
branch
3 times, most recently
from
8ff74cd
to
3bdfb34
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
deepakkinni
reviewed
Oct 25, 2024
adikul30
force-pushed
the
topic/aditya/fallback-session
branch
4 times, most recently
from
be12e4e
to
8fbfe2c
Compare
adikul30
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
fallback is to restart the container
adikul30
force-pushed
the
topic/aditya/fallback-session
branch
from
8fbfe2c
to
54f5c33
Compare
adikul30
commented
Oct 31, 2024
| @@ -256,10 +291,10 @@ func (l *ListViewImpl) SetListViewNotReady(ctx context.Context) { | |||
|
|
|||
| func (l *ListViewImpl) connect() error { | |||
| log := logger.GetLogger(l.ctx) | |||
| log.Infof("waiting for lock before calling connect") | |||
| log.Debugf("waiting for lock before calling connect") | |||
There was a problem hiding this comment.
Changing this to debug as the routine will call it every 30 seconds.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adikul30, deepakkinni, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#3064 refactors the session management logic in
ListView package. As a fallback option, if we still run into a state where the credentials are valid but we've not been able to get the listview into a ready state, we should restart the container. This will help customers not run into this state for an extended period of time.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Testing done:
Validated by QE.
Special notes for your reviewer:
Release note: