Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging to debug to reduce spew #3070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deepakkinni
Copy link
Contributor

What this PR does / why we need it:
While triaging Perf bug, noticed the whole syncer logs littered with info level messages regarding kubeconfig. Reducing it to debug level.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
syncer logs:

{"level":"info","time":"2024-09-27T17:49:01.398998633Z","caller":"storagepool/intended_state.go:359","msg":"Updating StoragePool instance for storagepool-vsandatastore-cluster1","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.405006792Z","caller":"kubernetes/kubernetes.go:107","msg":"Kubeconfig flag is set but empty, checking environment variable value","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.405045154Z","caller":"kubernetes/kubernetes.go:115","msg":"Kubeconfig path obtained from environment variable \"KUBECONFIG\": \"\"","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.405055714Z","caller":"kubernetes/kubernetes.go:120","msg":"No Kubeconfig path found, either from environment variable or flag","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.4050643Z","caller":"kubernetes/kubernetes.go:82","msg":"k8s client using in-cluster config","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.405222678Z","caller":"kubernetes/kubernetes.go:434","msg":"Setting client QPS to 200.000000 and Burst to 200.","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.408598523Z","caller":"kubernetes/kubernetes.go:107","msg":"Kubeconfig flag is set but empty, checking environment variable value","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}
{"level":"info","time":"2024-09-27T17:49:01.408633639Z","caller":"kubernetes/kubernetes.go:115","msg":"Kubeconfig path obtained from environment variable \"KUBECONFIG\": \"\"","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"bc58fa87-6d56-4473-8785-262283067d95"}



{"level":"info","time":"2024-09-27T17:47:00.688865991Z","caller":"syncer/fullsync.go:1217","msg":"FullSync for VC w1hs5-testvc3.eng.vmware.com: update is not required for volume: \"cee3ba3d-12e9-4bd6-b1fe-78c43cd7a556\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:47:00.689138304Z","caller":"syncer/fullsync.go:1217","msg":"FullSync for VC w1hs5-testvc3.eng.vmware.com: update is not required for volume: \"6b45b9e5-8291-48ab-becf-1f11543dbcff\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:47:00.68941762Z","caller":"syncer/fullsync.go:1217","msg":"FullSync for VC w1hs5-testvc3.eng.vmware.com: update is not required for volume: \"4ea84130-313d-4091-bbac-4b9b90b0a9cb\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:47:00.689695583Z","caller":"syncer/fullsync.go:1217","msg":"FullSync for VC w1hs5-testvc3.eng.vmware.com: update is not required for volume: \"5d043629-9832-4a95-8181-0481e3ba9d11\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:47:00.689962005Z","caller":"syncer/fullsync.go:1217","msg":"FullSync for VC w1hs5-testvc3.eng.vmware.com: update is not required for volume: \"e3e22883-6cde-4c4a-a4aa-dee28d01a121\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}


{"level":"info","time":"2024-09-27T17:46:58.265800406Z","caller":"syncer/fullsync.go:790","msg":"Received aggregatedSnapshotCapacity 0 for volume \"daa35fda-2321-4d61-be4e-2871a514a3de\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265827377Z","caller":"syncer/fullsync.go:782","msg":"validate volume info for storage details for volume 6e254da9-57a1-4e04-a637-77bfe43daa93","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.26583473Z","caller":"syncer/fullsync.go:790","msg":"Received aggregatedSnapshotCapacity 0 for volume \"6e254da9-57a1-4e04-a637-77bfe43daa93\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265863695Z","caller":"syncer/fullsync.go:782","msg":"validate volume info for storage details for volume fa46ef09-bed3-4f02-94b2-406d52e08431","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.26587154Z","caller":"syncer/fullsync.go:790","msg":"Received aggregatedSnapshotCapacity 0 for volume \"fa46ef09-bed3-4f02-94b2-406d52e08431\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265899162Z","caller":"syncer/fullsync.go:782","msg":"validate volume info for storage details for volume f495b2d0-9b99-4156-b901-8bc29e3b8963","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265905143Z","caller":"syncer/fullsync.go:790","msg":"Received aggregatedSnapshotCapacity 0 for volume \"f495b2d0-9b99-4156-b901-8bc29e3b8963\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265931483Z","caller":"syncer/fullsync.go:782","msg":"validate volume info for storage details for volume 8bf32915-022d-43f4-938a-f4451b95399f","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265937564Z","caller":"syncer/fullsync.go:790","msg":"Received aggregatedSnapshotCapacity 0 for volume \"8bf32915-022d-43f4-938a-f4451b95399f\"","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}
{"level":"info","time":"2024-09-27T17:46:58.265965006Z","caller":"syncer/fullsync.go:782","msg":"validate volume info for storage details for volume b01ee2ca-45d0-409f-97f2-a5085bdaf525","TraceId":"43fdb55e-db1f-4740-a2c0-3e15b91b1eaa"}

{"level":"info","time":"2024-09-27T17:21:58.849709366Z","caller":"storagepool/intended_state.go:326","msg":"Host w1-hs5-b0209.eng.vmware.com has capacity &{Capacity:11522235432960 CapacityReserved:94136958976 CapacityUsed:265617512857 HostMoID:host-22}","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.870455693Z","caller":"storagepool/intended_state.go:326","msg":"Host w1-hs5-b0207.eng.vmware.com has capacity &{Capacity:11522235432960 CapacityReserved:59437481984 CapacityUsed:252187351449 HostMoID:host-13}","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.870473897Z","caller":"storagepool/intended_state.go:231","msg":"creating vsan sna sp \"w1-hs5-b0208.eng.vmware.com\"","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.873814679Z","caller":"storagepool/intended_state.go:359","msg":"Updating StoragePool instance for storagepool-vsandatastore-cluster1-w1-hs5-b0208.eng.vmware.com","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.878843776Z","caller":"storagepool/intended_state.go:231","msg":"creating vsan sna sp \"w1-hs5-b0209.eng.vmware.com\"","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.882279125Z","caller":"storagepool/intended_state.go:359","msg":"Updating StoragePool instance for storagepool-vsandatastore-cluster1-w1-hs5-b0209.eng.vmware.com","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.888026588Z","caller":"storagepool/intended_state.go:231","msg":"creating vsan sna sp \"w1-hs5-b0207.eng.vmware.com\"","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.891290837Z","caller":"storagepool/intended_state.go:359","msg":"Updating StoragePool instance for storagepool-vsandatastore-cluster1-w1-hs5-b0207.eng.vmware.com","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:58.903848556Z","caller":"storagepool/listener.go:210","msg":"Scheduled ReconcileAllStoragePools completed","TraceId":"99b6da0e-87b5-4888-8891-ed851adca593","TraceId":"f263a631-00b0-4db7-bc9f-5c04f17f862f"}
{"level":"info","time":"2024-09-27T17:21:59.373867534Z","caller":"syncer/volume_health.go:127","msg":"GetVolumeHealthStatus: end","TraceId":"8f542ddd-b57b-4ffe-a1ac-128bd294fd90"}

Unit tests.

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakkinni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants