Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): First stab at structured contextual logging via go-logr API #292

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Jan 26, 2024

Minimal changes proposal for support of logging verbosity levels.

Start detailed logging at higher verbosity levels for debugging convenience.


This proposes minimal
Replaces #291 as follow-up to suggestion from #291 (comment)


Usage example

.\swdt.ps1 setup --config .\experiments\swdt\samples\mloskot\winworker.yaml --v 2

Add support to logging verbosity levels.
Start detailed logging at higher verbosity levels
for debugging convenience.

Signed-off-by: Mateusz Łoskot <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloskot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@mloskot
Copy link
Contributor Author

mloskot commented Jan 26, 2024

/assign @knabben

I am not 100% sure I've got the go.mod update right :)

Copy link
Member

@knabben knabben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2024
@knabben
Copy link
Member

knabben commented Jan 28, 2024

/assign @knabben

I am not 100% sure I've got the go.mod update right :)

Pretty much, you can go mod tidy locally, and go will figure out deps. The unit test job do the same before running

@k8s-ci-robot k8s-ci-robot merged commit 58d7c6f into kubernetes-sigs:master Jan 28, 2024
4 checks passed
@mloskot
Copy link
Contributor Author

mloskot commented Jan 28, 2024

/assign @knabben

I am not 100% sure I've got the go.mod update right :)

Pretty much, you can go mod tidy locally, and go will figure out deps. The unit test job do the same before running

Good. I think I did it with go mod tidy. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants