-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use Capabilities.KubeVersion
in helm charts
#72
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle chore: Use |
Capabilities.KubeVersion
in helm charts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the yamls in the manifest_staging/charts folder and revert any changes in charts/
.
manifest_staging
folder is where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.
Done |
/assign @nilekhc |
/lgtm |
Found #78 as part of testing this. |
/retest |
/test all |
This is failing because we are relying solely on the Kubernetes version to determine the availability of the VAP resources in the tests and not altering the cluster config, which isn't always true because feature gates might not be enabled. To fix this we will need to vary the cluster config provided for each test. Should we document somewhere that if installing with a version before 1.30.0 (when VAPs were classed as stable) a user may need to alter their cluster config? @nilekhc |
/test all |
/retest-required |
@omerap12, we need to modify local-setup such that it takes correct feature gate in kind-config.yaml while creating cluster. |
Ill take a look into it |
Signed-off-by: Omer Aplatony <[email protected]> Signed-off-by: Omer Aplatony <[email protected]>
New changes are detected. LGTM label has been removed. |
@omerap12: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Use Capabilities.KubeVersion instead of kubernetesReleaseVersion value
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #61
Special notes for your reviewer:
TODOs: