Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use Capabilities.KubeVersion in helm charts #72

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omerap12
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
Use Capabilities.KubeVersion instead of kubernetesReleaseVersion value
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #61

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign enj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
@aramase
Copy link
Member

aramase commented Aug 28, 2024

/retitle chore: Use Capabilities.KubeVersion in helm charts

@k8s-ci-robot k8s-ci-robot changed the title Helm: Use Capabilities.KubeVersion instead of kubernetesReleaseVersion value chore: Use Capabilities.KubeVersion in helm charts Aug 28, 2024
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the yamls in the manifest_staging/charts folder and revert any changes in charts/.

manifest_staging folder is where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2024
@omerap12
Copy link
Member Author

Please update the yamls in the manifest_staging/charts folder and revert any changes in charts/.

manifest_staging folder is where we host the staging charts and deployment yamls. All the yaml changes will then be promoted into the released charts folder with the next release.

Done

@aramase
Copy link
Member

aramase commented Sep 3, 2024

/assign @nilekhc

@nilekhc
Copy link
Contributor

nilekhc commented Sep 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@aramase
Copy link
Member

aramase commented Sep 5, 2024

Found #78 as part of testing this.

@nilekhc
Copy link
Contributor

nilekhc commented Sep 13, 2024

/retest

@nilekhc
Copy link
Contributor

nilekhc commented Sep 13, 2024

/test all

@AlexanderStocks
Copy link
Contributor

AlexanderStocks commented Sep 20, 2024

This is failing because we are relying solely on the Kubernetes version to determine the availability of the VAP resources in the tests and not altering the cluster config, which isn't always true because feature gates might not be enabled. To fix this we will need to vary the cluster config provided for each test. Should we document somewhere that if installing with a version before 1.30.0 (when VAPs were classed as stable) a user may need to alter their cluster config? @nilekhc

@nilekhc
Copy link
Contributor

nilekhc commented Sep 23, 2024

/test all

@aramase
Copy link
Member

aramase commented Oct 3, 2024

/retest-required

@nilekhc
Copy link
Contributor

nilekhc commented Oct 7, 2024

This is failing because we are relying solely on the Kubernetes version to determine the availability of the VAP resources in the tests and not altering the cluster config, which isn't always true because feature gates might not be enabled. To fix this we will need to vary the cluster config provided for each test. Should we document somewhere that if installing with a version before 1.30.0 (when VAPs were classed as stable) a user may need to alter their cluster config? @nilekhc

@omerap12, we need to modify local-setup such that it takes correct feature gate in kind-config.yaml while creating cluster.

@omerap12
Copy link
Member Author

omerap12 commented Oct 7, 2024

This is failing because we are relying solely on the Kubernetes version to determine the availability of the VAP resources in the tests and not altering the cluster config, which isn't always true because feature gates might not be enabled. To fix this we will need to vary the cluster config provided for each test. Should we document somewhere that if installing with a version before 1.30.0 (when VAPs were classed as stable) a user may need to alter their cluster config? @nilekhc

@omerap12, we need to modify local-setup such that it takes correct feature gate in kind-config.yaml while creating cluster.

Ill take a look into it

@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

@omerap12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-sync-controller-e2e-provider-k8s-1-30-2 5146fdb link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-30-2
pull-secrets-store-sync-controller-e2e-provider-k8s-1-28-11 5146fdb link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-28-11
pull-secrets-store-sync-controller-e2e-provider-k8s-1-27-15 5146fdb link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-27-15
pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-6 5146fdb link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-6
pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-8 eaafbb3 link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-8

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Capabilities.KubeVersion in helm charts to determine the API version
5 participants