Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add metrics #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add metrics #53

wants to merge 1 commit into from

Conversation

AlexanderStocks
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds metrics in the style of the CSI Driver to the sssc. Adds a service to access the metrics.

Which issue(s) this PR fixes:
Fixes #7

Special notes for your reviewer:
This currently does not include any test or documentation, let me know if/how you would like these added.
TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlexanderStocks
Once this PR has been reviewed and has the lgtm label, please assign enj for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @AlexanderStocks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 15, 2024
@AlexanderStocks AlexanderStocks changed the title Astocks/add metrics feat: Add metrics Aug 15, 2024
@AlexanderStocks
Copy link
Contributor Author

/cc @nilekhc

@AlexanderStocks
feat: add metrics
aa85462 
Initial setup

feat: add metrics

Undo changes for local testing
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 16, 2024
@nilekhc
Copy link
Contributor

nilekhc commented Sep 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

@AlexanderStocks: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-sync-controller-unit aa85462 link true /test pull-secrets-store-sync-controller-unit
pull-secrets-store-sync-controller-lint aa85462 link true /test pull-secrets-store-sync-controller-lint
pull-secrets-store-sync-controller-e2e-provider-k8s-1-28-13 aa85462 link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-28-13
pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-8 aa85462 link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-29-8
pull-secrets-store-sync-controller-e2e-provider-k8s-1-30-4 aa85462 link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-30-4
pull-secrets-store-sync-controller-e2e-provider-k8s-1-31-0 aa85462 link true /test pull-secrets-store-sync-controller-e2e-provider-k8s-1-31-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nilekhc
Copy link
Contributor

nilekhc commented Oct 8, 2024

@AlexanderStocks Looks like tests are failing. Could you PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase Awaiting requested review from aramase

@enj enj Awaiting requested review from enj

@nilekhc nilekhc Awaiting requested review from nilekhc

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics
3 participants
@AlexanderStocks @k8s-ci-robot @nilekhc