explicit protocol selection with appProtocol

[seankhliao]

What this PR does / why we need it:

For reasons not entirely clear to me, our istio installation doesn't recognize the protocol as https based on the port naming, resulting in the istio proxy inappropriately terminating the api-server->metrics-server TLS connection. Our testing shows that istio will use the appProtocol: https setting if provided, it should have no negative impact on other environments

[k8s-ci-robot]

Hi @seankhliao. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yangjunmyfm192085]

It looks like this is a feature of istio
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/

[logicalhan]

/assign @yangjunmyfm192085
/triage accepted

[dgrisonnet]

/lgtm
/approve

[dgrisonnet]

It looks like this is a feature of istio
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/

appProtocol is a native Kubernetes field https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol so it is fine to add it here even if it might just help istio users for now

[yangjunmyfm192085]

/retest

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, seankhliao, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dgrisonnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yangjunmyfm192085]

/ok-to-test