[doc] Add a page for inject failure demo #1144
Conversation
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
the
kind/documentation
|
@wzshiming: GitHub didn't allow me to request PR reviews from the following users: network-charles. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
kind/feature
✅ Deploy Preview for k8s-kwok ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/M
There was a problem hiding this comment.
There was a problem hiding this comment.
This should meet the need to reference other files to be displayed on the page
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
| {{< /expand >}} | ||
|
|
||
| {{< expand "failed-pod.yaml" >}} | ||
|
|
||
| {{< code-sample file="failed-pod.yaml" >}} | ||
|
|
||
| {{< /expand >}} |
There was a problem hiding this comment.
So are you saying I can reference each file this way?
If yes, do I specify the file path to any file I want to reference?
For example, on the simulation.md file I can add the below to reference the node.yaml file:
{{< /expand >}}
{{< expand "demo/technical-outcomes/simulation/scenario-1/node.yaml" >}}
{{< code-sample file="demo/technical-outcomes/simulation/scenario-1/node.yaml" >}}
{{< /expand >}}There was a problem hiding this comment.
Yes, this is because it is the same directory, so it can omit the path.
https://github.com/kubernetes-sigs/kwok/tree/main/site/content/en/docs/user/examples/injectfailure
There was a problem hiding this comment.
Lovely. Will this PR be merged today?
There was a problem hiding this comment.
Ah, I'll merge this #1145
wzshiming
force-pushed
the
doc/code-sample-demo
branch
2 times, most recently
from
c96b72d
to
4669495
Compare
wzshiming
changed the title
wzshiming
force-pushed
the
doc/code-sample-demo
branch
from
4669495
to
cb4bde5
Compare
k8s-ci-robot
added
size/S
wzshiming
force-pushed
the
doc/code-sample-demo
branch
from
cb4bde5
to
43c0f75
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wzshiming, yuanchen8911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind documentation
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
code-sampleDoes this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @yuanchen8911
/cc @network-charles