Do not serialize fact gathering for no_proxy #11598
Open
+52
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
This essentially reverts #5957 , which means it gather ansible_default_ipv4 in parallel.
This means that using kubespray with --limits depends on the fact cache, but given that we have a dedicated playbook just for that and that it's the documented supported behavior, that makes it ok in my book.
Which issue(s) this PR fixes:
Fixes #11587
(I think it does, @sirkrypt0 could you test that patch to confirm ?)
Special notes for your reviewer:
This might need refinement but I'd like to test if the approach works.
Does this PR introduce a user-facing change?:
@rptaylor Thought this might interest you.
/label tide/merge-method-merge