-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #11265
base: master
Are you sure you want to change the base?
Update CONTRIBUTING.md #11265
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yi-ymmt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @yi-ymmt! |
Hi @yi-ymmt. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@yi-ymmt: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
1 similar comment
/retest |
You need to rebase to get the CI fix.
|
/retest |
tests/requirements.yml was deleted in ef95eb0
HI @MrFreezeex |
@@ -12,7 +12,6 @@ To install development dependencies you can set up a python virtual env with the | |||
virtualenv venv | |||
source venv/bin/activate | |||
pip install -r tests/requirements.txt | |||
ansible-galaxy install -r tests/requirements.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yi-ymmt can you explain benifit of removing it?
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Help for those who want to contribute
Does this PR introduce a user-facing change?: