-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add docs for nerdctl support #3532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
https://kind.sigs.k8s.io/docs/user/rootless/ should be updated too |
I also guess that |
Thanks, it has been updated. |
site/content/docs/user/rootless.md
Outdated
@@ -80,5 +81,12 @@ On some distributions, you might need to use systemd-run to start kind into its | |||
$ systemd-run --scope --user kind create cluster | |||
``` | |||
|
|||
## Creating a kind cluster with Rootless Nerdctl | |||
|
|||
To create a kind cluster with Nerdctl Podman, just run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To create a kind cluster with Nerdctl Podman, just run: | |
To create a kind cluster with nerdctl, just run: |
site/content/docs/user/rootless.md
Outdated
|
||
## Provider requirements | ||
- Docker: 20.10 or later | ||
- Podman: 3.0 or later | ||
- Nerdctl: 1.7 or later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe s/Nerdctl/nerdctl/g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it has been updated.
And add some docs for KIND_EXPERIMENTAL_PROVIDER
: https://github.com/kubernetes-sigs/kind/pull/3532/files#diff-40a589d72dc1d461ea36579cd051d1adf7ca6ea6bdc2c7dcda6a714130910486
Thanks @nunix Because I do have a finch WSL environment, I can only try to reproduce the issue in Ubuntu Linux.
It can work correctly without Would you please help to provide the output with commands
to help me invesgate the issue :-) |
Co-authored-by: Sean McGinnis <[email protected]> Signed-off-by: Kay Yan <[email protected]>
@yankay certainly, here's the output (screenshot just for proof): On the KinD side, I generated the binary from WSL2 Finch distro with the command Finally, I also built Same as before with hope this helps and please let me know if I need to run specific commands for building it on WSL2/Windows. |
@@ -144,6 +144,9 @@ wait for 30 seconds, do `--wait 30s`, for 5 minutes do `--wait 5m`, etc. | |||
|
|||
More usage can be discovered with `kind create cluster --help`. | |||
|
|||
The kind can auto-detect the [docker], [podman], or [nerdctl] installed and choose the available one. If you want to turn off the auto-detect, use the environment variable `KIND_EXPERIMENTAL_PROVIDER=docker`, `KIND_EXPERIMENTAL_PROVIDER=podman` or `KIND_EXPERIMENTAL_PROVIDER=nerdctl` to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nunix is your concern addressed by this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aojea yes all good on my side for the comment.
I will try again the auto-detect when the 0.23 is out maybe, as what I was trying to test was actually the auto-detect. But it's maybe on my side and with the comment, it provides the needed help.
waiting for resolving the last comment |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, aojea, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After the #3429, the nerdctl is supported.
So add it to the docs.