Fix the location of the containerd state/root folders for Windows

[jsturtevant]

What this PR does / why we need it:

The intent was to have the data folders (state and root be in c:\programdata\containerd\:

image-builder/images/capi/ansible/windows/roles/runtimes/tasks/containerd.yml

Lines 31 to 33 in 196c549

	- '{{ programfiles.stdout | trim }}\containerd'
	- '{{ alluserprofile.stdout | trim }}\containerd\state'
	- '{{ alluserprofile.stdout | trim }}\containerd\root'

but the didn't land there due to wrong config:

image-builder/images/capi/ansible/windows/roles/runtimes/templates/config.toml

Lines 15 to 16 in 196c549

	root = "{{ allusersprofile }}\\root"
	state = "{{ allusersprofile }}\\state"

This puts them in the correct location. This should be a non breaking change as it is not user facing but will be less confusing for an admin looking for these folders (right now there are in c:\programdata\root but there are folders in c:\programdata\containerd\

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Additional context
Add any other context for the reviewers

/sig windows
/assign @perithompson

[jsturtevant]

the ubuntu 18.04 image failed:

�[0;32m    vhd-ubuntu-1804: TASK [providers : install Azure clients] ***************************************�[0m
�[0;32m    vhd-ubuntu-1804: fatal: [default]: FAILED! => {"changed": false, "cmd": ["/usr/bin/pip3", "install", "azure-cli"], "msg": "stdout: Collecting azure-cli\n  Downloading https://files.pythonhosted.org/packages/ba/5a

/retest

[jsturtevant]

I think my goss validation command is incorrect:

�[0;32m    vhd-windows-2022-containerd:             
"summary-line": "Command: Correct Containerd cni config: stdout: patterns not found:
 [root = \"C:\\ProgramData\\containerd\\root\", state = \"C:\\ProgramData\\containerd\\state\"]",�[0m

[jsturtevant]

this is awkward due to the face that we have some forward slashs and some backward slashes. I opened #767 to track fixing this. The code it's self doesn't care but we should be consistent across the project

[jsturtevant]

/assign @knabben

[knabben]

@jsturtevant do you need help to test on vsphere?

[knabben]

otherwise /lgtm

[jsturtevant]

I don't have a vsphere environment. Do you want to test it? The OVA job doesn't have a windows test in but maybe that could be an improvement in the test suite

[knabben]

@jsturtevant sorry for the delay - finished testing it on vsphere

/lgtm

[2022-03-16T01:41:17.102Z]     vsphere: TASK [runtimes : Create containerd directory structure] ************************
[2022-03-16T01:41:17.102Z]     vsphere: changed: [default] => (item=C:\Program Files\containerd)
[2022-03-16T01:41:18.480Z]     vsphere: changed: [default] => (item=C:\\ProgramData\containerd\state)
[2022-03-16T01:41:19.863Z]     vsphere: changed: [default] => (item=C:\\ProgramData\containerd\root)
[2022-03-16T01:41:21.238Z]     vsphere: changed: [default] => (item=C:/opt/cni/bin)
[2022-03-16T01:41:23.150Z]     vsphere: changed: [default] => (item=C:/etc/cni/net.d)

.... goss ---

{
[2022-03-16T01:48:30.793Z]     vsphere:             "duration": 0,
[2022-03-16T01:48:30.793Z]     vsphere:             "err": null,
[2022-03-16T01:48:30.793Z]     vsphere:             "expected": [
[2022-03-16T01:48:30.793Z]     vsphere:                 "sandbox_image = \"projects-stg.registry.vmware.com/tkg/pause:3.4.1-windows-amd64\"",
[2022-03-16T01:48:30.793Z]     vsphere:                 "conf_dir = \"C:/etc/cni/net.d\"",
[2022-03-16T01:48:30.793Z]     vsphere:                 "bin_dir = \"C:/opt/cni/bin\"",
[2022-03-16T01:48:30.793Z]     vsphere:                 "root = \"C:\\\\ProgramData\\\\containerd\\\\root\"",
[2022-03-16T01:48:30.794Z]     vsphere:                 "state = \"C:\\\\ProgramData\\\\containerd\\\\state\""
[2022-03-16T01:48:30.794Z]     vsphere:             ],
[2022-03-16T01:48:30.794Z]     vsphere:             "found": [
[2022-03-16T01:48:30.794Z]     vsphere:                 "root = \"C:\\\\ProgramData\\\\containerd\\\\root\"",
[2022-03-16T01:48:30.794Z]     vsphere:                 "state = \"C:\\\\ProgramData\\\\containerd\\\\state\"",
[2022-03-16T01:48:30.794Z]     vsphere:                 "sandbox_image = \"projects-stg.registry.vmware.com/tkg/pause:3.4.1-windows-amd64\"",
[2022-03-16T01:48:30.794Z]     vsphere:                 "bin_dir = \"C:/opt/cni/bin\"",
[2022-03-16T01:48:30.794Z]     vsphere:                 "conf_dir = \"C:/etc/cni/net.d\""
[2022-03-16T01:48:30.794Z]     vsphere:             ],
[2022-03-16T01:48:30.794Z]     vsphere:             "human": "",
[2022-03-16T01:48:30.794Z]     vsphere:             "meta": null,
[2022-03-16T01:48:30.794Z]     vsphere:             "property": "stdout",
[2022-03-16T01:48:30.794Z]     vsphere:             "resource-id": "Correct Containerd config",
[2022-03-16T01:48:30.794Z]     vsphere:             "resource-type": "Command",
[2022-03-16T01:48:30.794Z]     vsphere:             "result": 0,
[2022-03-16T01:48:30.794Z]     vsphere:             "successful": true,
[2022-03-16T01:48:30.794Z]     vsphere:             "summary-line": "Command: Correct Containerd config: stdout: matches expectation: [sandbox_image = \"projects-stg.registry.vmware.com/tkg/pause:3.4.1-windows-amd64\" conf_dir = \"C:/etc/cni/net.d\" bin_dir = \"C:/opt/cni/bin\" root = \"C:\\\\ProgramData\\\\containerd\\\\root\" state = \"C:\\\\ProgramData\\\\containerd\\\\state\"]",

containerd

PS C:\Users\capv> ls C:\ProgramData\containerd\root


    Directory: C:\ProgramData\containerd\root


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        3/16/2022   1:41 AM                io.containerd.content.v1.content
d-----        3/16/2022   1:41 AM                io.containerd.metadata.v1.bolt
d-----        3/16/2022   1:41 AM                io.containerd.runtime.v2.task
d-----        3/16/2022   1:41 AM                io.containerd.snapshotter.v1.windows
d-----        3/16/2022   1:41 AM                io.containerd.snapshotter.v1.windows-lcow
d-----        3/16/2022   1:41 AM                opt
-a----        3/16/2022   2:03 AM              0 panic.log


PS C:\Users\capv> ls C:\ProgramData\containerd\state


    Directory: C:\ProgramData\containerd\state


Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----        3/16/2022   1:41 AM                io.containerd.runtime.v2.task

[CecileRobertMichon]

/approve

[CecileRobertMichon]

/approve

[jsturtevant]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• images/capi/OWNERS [CecileRobertMichon,jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment