-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline for Azure community gallery image publishing #1578
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
b7817e2
to
38e538d
Compare
9fa19b0
to
d920039
Compare
d920039
to
952d5de
Compare
This actually passed CI, modulo two unrelated flakes. |
/retitle Add pipeline for Azure community gallery image publishing |
[[ -n ${DEBUG:-} ]] && set -o xtrace | ||
|
||
tracestate="$(shopt -po xtrace)" | ||
set +o xtrace | ||
if [[ -n "${AZURE_FEDERATED_TOKEN_FILE:-}" ]]; then | ||
if [[ "${USE_AZURE_CLI_AUTH:-}" == "True" ]]; then | ||
: # Assume we did "az login" before running this script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case is used in the ADO pipelines now, to avoid trying to log in again. Instead, we use managed ID-compatible DevOps tasks such as AzureCLI@2
, which provides a bash
shell with az
already logged in according to credentials specified in a Service Connection defined in ADO.
/lgtm |
410937a
to
7074eac
Compare
I squashed the commits, should be ready to go. |
/lgtm |
/test pull-azure-vhds |
/retest Flake (I think) with windows-2025:
This PR doesn't really touch any code that would be relevant here. |
/assign @AverageMarcus @drew-viles @jsturtevant I've been using this branch in the actual pipeline for a while, and it's working well. |
7074eac
to
7fe99b7
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change description
Replaces the Azure DevOps pipeline scripts with a new flow that publishes to a Community gallery.
Related issues
Additional context
This is simpler in the end than publishing to Azure Marketplace, and agrees with what we recommend in the CAPZ book. Additionally, the current Azure Packer plugin won't support the SAS key generation necessary to publish VHDs via the existing pipeline, and internal security requirements have made that flow problematic.