-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump default Kubernetes to 1.29.7 #1533
Bump default Kubernetes to 1.29.7 #1533
Conversation
I'm not sure we should skip major version when bumping. I think at the very least we should do the latest v1.29 first and then create a release of that then do another bumping to v1.30. (Edit: I just noticed that in the previous bump we did skip versions so I guess not too bad but still I think it would be best to have a specific release per version) It's also worth being clear that v1.31 isn't officially released yet. As of 4 hours ago the second release candidate was released so it should be soon but it's still considered a pre-release and not a production release yet. @mboersma @jsturtevant @drew-viles would be good to get your thoughts too. I don't think we've ever had anything officially wrote down for what version we target but I think we've informally followed the oldest still in support. |
Yeah iirc the 13th or 14th is the target date for release of 1.31. I'd be happy with an eventual bump to 1.30, as in I'm not against jumping a couple of versions. But, for the sake of having a sensible path of migration, I'd say we need to at least have one release with a 1.29 bump first. That way should anyone experience an issue with a 1.30 release, they have a rollback option. |
Okay, then I will update this PR to target latest v1.29 |
/retest Looks like a flake on Ubuntu 22.04. |
(BTW, the pull-ova-all job was supposed to fail starting August 1, but it seems Google gave an additional week grace period before actually pulling the plug. So test ‘em while ya got ‘em.) |
@mloiseleur: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
One of the parts of the “reset temp space” task seems to be failing, only for Ubuntu 22.04. This seems unlikely to be related to this PR, but we should investigate. |
I took some times to understand what is this test and what is happening, based on logs available in artifacts tab, here. The ansible code for Reset temp space is here. I'm not sure to understand why (since it's a tmpfs): it tries to delete all files in The log says it cannot on So far, my guess is that there is a snapshot triggered or already pre-existing, and since this snapshot file is used, it cannot be deleted. Removing the code in ansible trying to remove some tmp files would probably turn this test green, but would this be ok to remove it ? |
I think we shouldn't, because the intent is to clean the disk image. We could maybe make it a "best effort" thing for Ubuntu 22.04 / vsphere if we can't figure out a better workaround. I wonder if adding something like this would work: ignore_errors: ansible_distribution_version is version('22.04', '>=') Regardless, the /lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AverageMarcus, drew-viles The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change description
Update to latest v1.29.
Latest PR on this subject: #1450