Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default Kubernetes to 1.29.7 #1533

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Aug 6, 2024

Change description

Update to latest v1.29.

Latest PR on this subject: #1450

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2024
@AverageMarcus
Copy link
Member

AverageMarcus commented Aug 6, 2024

I'm not sure we should skip major version when bumping. I think at the very least we should do the latest v1.29 first and then create a release of that then do another bumping to v1.30. (Edit: I just noticed that in the previous bump we did skip versions so I guess not too bad but still I think it would be best to have a specific release per version)

It's also worth being clear that v1.31 isn't officially released yet. As of 4 hours ago the second release candidate was released so it should be soon but it's still considered a pre-release and not a production release yet.

@mboersma @jsturtevant @drew-viles would be good to get your thoughts too. I don't think we've ever had anything officially wrote down for what version we target but I think we've informally followed the oldest still in support.

@drew-viles
Copy link
Contributor

drew-viles commented Aug 6, 2024

Yeah iirc the 13th or 14th is the target date for release of 1.31.

I'd be happy with an eventual bump to 1.30, as in I'm not against jumping a couple of versions. But, for the sake of having a sensible path of migration, I'd say we need to at least have one release with a 1.29 bump first. That way should anyone experience an issue with a 1.30 release, they have a rollback option.

@mloiseleur
Copy link
Contributor Author

Okay, then I will update this PR to target latest v1.29

@mloiseleur mloiseleur changed the title Bump default Kubernetes to 1.30.3 Bump default Kubernetes to 1.29.7 Aug 6, 2024
@mboersma
Copy link
Contributor

mboersma commented Aug 6, 2024

/retest

Looks like a flake on Ubuntu 22.04.

@mboersma
Copy link
Contributor

mboersma commented Aug 6, 2024

(BTW, the pull-ova-all job was supposed to fail starting August 1, but it seems Google gave an additional week grace period before actually pulling the plug. So test ‘em while ya got ‘em.)

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ova-all 5304992 link false /test pull-ova-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor

mboersma commented Aug 6, 2024

One of the parts of the “reset temp space” task seems to be failing, only for Ubuntu 22.04. This seems unlikely to be related to this PR, but we should investigate.

@mloiseleur
Copy link
Contributor Author

mloiseleur commented Aug 6, 2024

I took some times to understand what is this test and what is happening, based on logs available in artifacts tab, here.

The ansible code for Reset temp space is here.

I'm not sure to understand why (since it's a tmpfs): it tries to delete all files in /tmp and /var/tmp

The log says it cannot on /tmp/snap.rootfs_6Priaa with errno 16 : Device or resource busy

So far, my guess is that there is a snapshot triggered or already pre-existing, and since this snapshot file is used, it cannot be deleted.

Removing the code in ansible trying to remove some tmp files would probably turn this test green, but would this be ok to remove it ?

@mboersma
Copy link
Contributor

mboersma commented Aug 7, 2024

would it be ok to remove it?

I think we shouldn't, because the intent is to clean the disk image. We could maybe make it a "best effort" thing for Ubuntu 22.04 / vsphere if we can't figure out a better workaround.

I wonder if adding something like this would work:

ignore_errors: ansible_distribution_version is version('22.04', '>=')

Regardless, the pull-ova-all job has been retired now as of kubernetes/test-infra#33245, so we can't verify any changes there until there is new infrastructure behind it (see #1508).

/lgtm
/assign @AverageMarcus @drew-viles

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@AverageMarcus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@drew-viles
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AverageMarcus, drew-viles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AverageMarcus,drew-viles]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6d63b8f into kubernetes-sigs:main Aug 8, 2024
11 checks passed
@mloiseleur mloiseleur deleted the bump-default-version branch October 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants