-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows 23H2 Datacenter offering as Windows Annual Channel for Azure #1528
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
1327b78
to
ddf4c80
Compare
"image_offer": "WindowsServer", | ||
"image_publisher": "MicrosoftWindowsServer", | ||
"image_sku": "23h2-datacenter-core", | ||
"image_version": "latest", | ||
"load_additional_components": "false", | ||
"runtime": "containerd", | ||
"shared_image_gallery_name": "{{env `GALLERY_NAME`}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep the below hack?
"source_sig_image_name": "{{env `SOURCE_SIG_IMAGE_NAME`}}",
"source_sig_image_version": "{{env `SOURCE_SIG_IMAGE_VERSION`}}",
"source_sig_name": "{{env `SOURCE_SIG_NAME`}}",
"source_sig_resource_group_name": "{{env `SOURCE_SIG_RESOURCE_GROUP`}}",
"source_sig_subscription_id": "{{env `SOURCE_SIG_SUB_ID`}}",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we don't need this as we will publish this image to the marketplace
sorry for the confusion, We want both sig and vhd versions of the make command, the latest updates look right for the sig, but will need to also add the vhd command to the make file |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
- update packer/azure/, makefile - reuse annual channel for win offering - remove sig information from the container json - update vhd and sig lists
018ea6d
to
fd2614d
Compare
/retest |
|
Pushed commit from my dev VM, will squash and push from local machine. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nawazkh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Change description
23h2-datacenter-core
as Windows Annual Channel with containers for SIG and VHD Image.Related issues
Additional context