Fix PowerVS builds by including wasm-shims file

[Amulyam24]

Change description

Removes unused variable containerd_wasm_shims_runtime_versions while copying containerd config file.

Related issues

• Fixes Building CAPI powervs and qemu images fail  #1466

Additional context

[Amulyam24]

/retest

[Amulyam24]

/cc @mboersma

[mboersma]

This should be a no-op overall: since containerd_wasm_shims_runtimes defaults to empty, it won't actually install anything. But it seems that /images/capi/packer/config/wasm-shims.json isn't included in the powervs/centos build.

What if instead of removing these lines in main.yml, we add packer/config/wasm-shims.json to COMMON_POWERVS_VAR_FILES? I think that will fix the build.

image-builder/images/capi/Makefile

Line 283 in 50a070a

COMMON_POWERVS_VAR_FILES := packer/config/kubernetes.json \

[Amulyam24]

This should be a no-op overall: since containerd_wasm_shims_runtimes defaults to empty, it won't actually install anything. But it seems that /images/capi/packer/config/wasm-shims.json isn't included in the powervs/centos build.

What if instead of removing these lines in main.yml, we add packer/config/wasm-shims.json to COMMON_POWERVS_VAR_FILES? I think that will fix the build.

image-builder/images/capi/Makefile

Line 283 in 50a070a

COMMON_POWERVS_VAR_FILES := packer/config/kubernetes.json \

Since containerd_wasm_shims_runtime is empty, I feel it is better to remove the var as a fix. Any particular reason that it was added?

[mboersma]

Any particular reason that it was added?

In #1037, the idea was that any distro could install the containerd-wasm-shims by populating the containerd_wasm_shims variable with one or more Wasm backends, but that by default that variable is empty. I think we just forgot to take into account PowerVS builds.

The simple and IMHO consistent fix would be to include that file. You could certainly argue it's cleaner not to include it all, since I don't think the containerd-wasm-shims are built for that architecture yet, but removing it from images/capi/ansible/roles/containerd/tasks/main.yml obviously breaks most other builds. Maybe you could just define containerd_wasm_shims_runtime_versions as an empty variable in the PowerVS JSON config file?

[Amulyam24]

Any particular reason that it was added?

In #1037, the idea was that any distro could install the containerd-wasm-shims by populating the containerd_wasm_shims variable with one or more Wasm backends, but that by default that variable is empty. I think we just forgot to take into account PowerVS builds.

The simple and IMHO consistent fix would be to include that file. You could certainly argue it's cleaner not to include it all, since I don't think the containerd-wasm-shims are built for that architecture yet, but removing it from images/capi/ansible/roles/containerd/tasks/main.yml obviously breaks most other builds. Maybe you could just define containerd_wasm_shims_runtime_versions as an empty variable in the PowerVS JSON config file?

Thanks @mboersma for clarifying, updated the changes. PTAL

[mboersma]

/lgtm
/assign @AverageMarcus @drew-viles

[mboersma]

/retitle Fix PowerVS builds by including wasm-shims file

[drew-viles]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drew-viles

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [drew-viles]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

Thanks again @Amulyam24! We don't have coverage of all targets in CI unfortunately, so we have to rely on intrepid community members like you to let us know when something is broken.