✨ Add custom path option for webhooks

[damsien]

This PR adds a way to configure mutating and validating webhooks using a custom path (for the HTTP call). It answer a problem described in this issue.

By default, the WebhookBuilder will generates the path using the generateMutatePath(gvk)/generateValidatePath(gvk) function. But if the user wants to use a custom path, it can build the WebhookBuilder using the WithCustomPath(customPath) function.

Example:

WebhookManagedBy(mgr).
	For(&TestDefaulter{}).
	WithDefaulter(&TestCustomDefaulter{}).
	WithCustomPath(customPath).
	Complete()

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: damsien / name: Damien (bfe6610)

[k8s-ci-robot]

Welcome @damsien!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @damsien. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alvaroaleman]

Idea makes a lot of sense, one comment

[alvaroaleman]

/ok-to-test

[damsien]

@alvaroaleman Done ✔️

[alvaroaleman]

This alters the path or not? Lets not do that, people might refernce the path in their Validating/MutatingWebhookConfiguration

[damsien]

@alvaroaleman if you're asking about the path.Clean() in the return section, it does not alter the final path, it only makes it cleaners. When I say it does not alter, it is in the way that the final path will act the same as the one provided by the user. For eg.

"//test" -> "/test"

So you want me to just return the customPath?

[alvaroaleman]

So you want me to just return the customPath?

I think so. I had a look at this and this is actually meant for filepaths, not for URLs. We are not dealing with untrusted input here, the double slash case you mentioned is probably confusing but not harmful. I think if for any reason we think the path we were given is wrong, we should return an error, otherwise the person who authors such code might not realize there is a problem

[damsien]

Okay I understand! Just removed it!

[alvaroaleman]

Thanks!

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 5b93965f39be021da08fe31a82f6451c13222653

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, damsien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment