-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add maxItems to all condition fields #11256
base: main
Are you sure you want to change the base?
Conversation
/assign @fabriziopandini |
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Note: should we also add this to the proposal?
LGTM label has been added. Git tree hash: e5ef53e72d01b50246c72a03d8a72b77a688cafa
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding limits to already shipped fields could be a breaking change, how are we arguing to mitigate that? (Or were these the ones that just merged?)
AFAIK these are only on new fields which we introduced with the other PR and are only on main :-) So should be good. |
All of these were just added with Fabrizio's PR |
But I guess overall we'll have to figure out how pragmatic we are with things like this for shipped APIs (I would say case-by-case decision). Because stuff like "adding CEL rules later" (or literally every additional validation) could be considered a breaking change |
Signed-off-by: Stefan Büringer [email protected]
96bbe99
to
d11927c
Compare
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added to the proposal as well + regen |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Found a few more places
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #