Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]✨ [DONT Review] Introduce new ClusterCache #11247

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP]✨ [DONT Review] Introduce new ClusterCache #11247

wants to merge 4 commits into from

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Oct 1, 2024 •
edited
Loading

What this PR does / why we need it:
I'm in the middle of implementing this PR, please do not review!!

Just want to run e2e tests for now

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10819
Fixes #9044

@sbueringer sbueringer added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sbueringer. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 1, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer changed the title [WIP][DONT Review] ✨ Introduce new ClusterCache [WIP]✨ [DONT Review] Introduce new ClusterCache Oct 1, 2024
@sbueringer sbueringer force-pushed the pr-cct-refactoring branch 2 times, most recently from d6bb5d9 to fd16439 Compare October 1, 2024 19:45
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

fabriziopandini
fabriziopandini reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Made a first pass on the clustercache package only

controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
controllers/clustercache/cluster_accessor.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Outdated Show resolved Hide resolved
controllers/clustercache/cluster_cache.go Show resolved Hide resolved
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main fe9a75d link false /test pull-cluster-api-apidiff-main
pull-cluster-api-test-main fe9a75d link true /test pull-cluster-api-test-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees
No one assigned
Labels
area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ClusterCacheTracker TryLock behavior Improve test coverage of ClusterCacheTracker
3 participants
@sbueringer @k8s-ci-robot @fabriziopandini