Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dual stack #1376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Nov 22, 2024

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Adding the ability to enable dual stacks.

Subnets are one of the resources that control the ability to use a dual stack (IPV4
and IPV6). These are required to be set on resource creation, and they cannot be
altered post creation.

The user has the option to set the stack type for each subnet (IPV4_ONLY, IPV4_IPV6, or
IPV6_ONLY). The default will be IPV4_ONLY.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # https://issues.redhat.com/browse/CORS-3762

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

 Adding the ability to enable dual stacks.
    
Subnets are one of the resources that control the ability to use a dual stack (IPV4 and IPV6). These are required to be set on resource creation, and they cannot be altered post creation.
    
The user has the option to set the stack type for each subnet (IPV4_ONLY, IPV4_IPV6, or IPV6_ONLY). The default will be IPV4_ONLY.

When creating compute.Subnetwork structs, set the StackType to the same value as the StackType in the SubnetSpecs.

Subnets are one of the resources that control the ability to use a dual stack (IPV4
and IPV6). These are required to be set on resource creation, and they cannot be
altered post creation.

The user has the option to set the stack type for each subnet (IPV4_ONLY, IPV4_IPV6, or
IPV6_ONLY). The default will be IPV4_ONLY.
…me value as

the StackType in the SubnetSpecs.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: barbacbd
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @barbacbd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2024
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 98db7cb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/6740aa98a112790008f0b89d
😎 Deploy Preview https://deploy-preview-1376--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants