Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cks cluster sync for a normal user #385

Merged

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented Jul 3, 2024

Issue #, if available:

Description of changes:

Fix CKS cluster sync for a normal user account. As of now, the request to create the cluster fails with the below error:

I0703 06:41:29.221156      14 base_reconciler.go:343] controllers/CKSClusterController "msg"="Failed creating ExternalManaged CKS cluster on CloudStack. error: CloudStack API error 432 (CSExceptionErrorCode: 9999): The API [getUser] does not exist or is not available for the account Account [{\"accountName\":\"ACSUser\",\"id\":4,\"uuid\":\"825b2028-c36a-4399-8560-442f5e587a2c\"}]. Requeuing." "name"="capc-cluster" "namespace"="default"

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2024
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit a0bb10c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/6684f41b66f12e00087a8391
😎 Deploy Preview https://deploy-preview-385--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.85%. Comparing base (d597e80) to head (a0bb10c).
Report is 57 commits behind head on main.

Files Patch % Lines
pkg/cloud/cks_cluster.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   25.66%   25.85%   +0.18%     
==========================================
  Files          59       62       +3     
  Lines        5563     4916     -647     
==========================================
- Hits         1428     1271     -157     
+ Misses       3996     3512     -484     
+ Partials      139      133       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Collaborator

/run-e2e

@blueorangutan
Copy link

@weizhouapache a jenkins job has been kicked to run test with following paramaters:

  • kubernetes version: 1.27.2
  • CloudStack version:
  • hypervisor: kvm
  • template: ubuntu-2004-kube
  • Kubernetes upgrade from: 1.26.5 to 1.27.2

@blueorangutan
Copy link

Setting up environment failed

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested capc cluster creation with normal user credentials and the external managed kubernetes cluster got created successfully

Screenshot 2024-07-03 at 2 57 28 PM

Screenshot 2024-07-03 at 2 58 40 PM

@k8s-ci-robot
Copy link
Contributor

@kiranchavala: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Tested capc cluster creation with normal user credentials and the external managed kubernetes cluster got created successfully

Screenshot 2024-07-03 at 2 57 28 PM

Screenshot 2024-07-03 at 2 58 40 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kiranchavala, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weizhouapache
Copy link
Collaborator

thanks @kiranchavala for the testing

based on @kiranchavala 's test result
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3ae856f into kubernetes-sigs:main Jul 3, 2024
10 checks passed
@rohityadavcloud rohityadavcloud added this to the v0.5.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants