Update to CAPI 1.5

[hrak]

Issue #, if available:

#285
#253

Description of changes:

This PR updates the cluster-api dependency to v1.5.5. It also updates to Go 1.20, updates golang-ci and addresses lint issues caught by the new version (mostly unused variables in function definitions)

Testing performed:

make test
test with kind

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
🔨 Latest commit	3c0fa55
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/66217253e287780008b8b2e8
😎 Deploy Preview	https://deploy-preview-342--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov-commenter]

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (7fd4146) 25.45% compared to head (6838e34) 25.38%.

❗ Current head 6838e34 differs from pull request most recent head dcdf474. Consider uploading reports for the commit dcdf474 to get more accurate results

Files	Patch %	Lines
controllers/cloudstackmachine_controller.go	58.33%	11 Missing and 4 partials ⚠️
controllers/cloudstackcluster_controller.go	37.50%	4 Missing and 1 partial ⚠️
api/v1beta3/cloudstackcluster_webhook.go	57.14%	3 Missing ⚠️
api/v1beta3/cloudstackmachine_webhook.go	57.14%	3 Missing ⚠️
api/v1beta3/cloudstackmachinetemplate_webhook.go	57.14%	3 Missing ⚠️
api/v1beta1/conversion.go	0.00%	2 Missing ⚠️
api/v1beta1/cloudstackaffinitygroup_conversion.go	0.00%	1 Missing ⚠️
...pi/v1beta1/cloudstackisolatednetwork_conversion.go	0.00%	1 Missing ⚠️
api/v1beta1/cloudstackmachine_conversion.go	0.00%	1 Missing ⚠️
...pi/v1beta1/cloudstackmachinetemplate_conversion.go	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
- Coverage   25.45%   25.38%   -0.08%     
==========================================
  Files          59       59              
  Lines        5555     5535      -20     
==========================================
- Hits         1414     1405       -9     
+ Misses       4002     3990      -12     
- Partials      139      140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rohityadavcloud]

I haven't tested it, but in theory we must upgrade to CAPI 1.5 or whatever may be the latest. I would want to see an easily v0.5 release.

/lgtm

[rohityadavcloud]

cc @shwstppr we'll need that CI fixed soon 🙏

[g-gaston]

/run-e2e -c 4.18
let's see if we get anything

[g-gaston]

/retest

[blueorangutan]

@g-gaston Invalid command: /run-e2e -c 4.18
let's see if we get anything

• Unsupported CloudStack version: 4.18
  let's

The command to run e2e test for CAPC.

Usage: /run-e2e [-k Kubernetes_Version] [-c CloudStack_Version] [-h Hypervisor] [-i Template/Image] [-f Kubernetes_Version_Upgrade_From] [-t Kubernetes_Version_Upgrade_To]

• Supported Kubernetes versions are: ['1.27.2', '1.26.5', '1.25.10', '1.24.14', '1.23.3', '1.22.6']. The default value is '1.27.2'.
• Supported CloudStack versions are: ['4.18', '4.17', '4.16']. If it is not set, an existing environment will be used.
• Supported hypervisors are: ['kvm', 'vmware', 'xen']. The default value is 'kvm'.
• Supported templates are: ['ubuntu-2004-kube', 'rockylinux-8-kube']. The default value is 'ubuntu-2004-kube'.
• By default it tests Kubernetes upgrade from version '1.26.5' to '1.27.2'.

Examples:

• /run-e2e
• /run-e2e -k 1.27.2 -h kvm -i ubuntu-2004-kube
• /run-e2e -k 1.27.2 -c 4.18 -h kvm -i ubuntu-2004-kube -f 1.26.5 -t 1.27.2

[rohityadavcloud]

/run-e2e -c 4.18

[blueorangutan]

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[pokearu]

/test capi-provider-cloudstack-presubmit-e2e-smoke-test

[pokearu]

Hi @g-gaston @rohityadavcloud I ran the e2e suit manually to test the CAPI changes. And got a successful run ✅

Not sure why the presubmit is failing, make run-e2e-smoke works for me locally just fine.

[rohityadavcloud]

/test capi-provider-cloudstack-presubmit-e2e-smoke-test

[rohityadavcloud]

/run-e2e -c 4.18

[blueorangutan]

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

• kubernetes version: 1.27.2
• CloudStack version: 4.18
• hypervisor: kvm
• template: ubuntu-2004-kube
• Kubernetes upgrade from: 1.26.5 to 1.27.2

[rohityadavcloud]

Thanks for testing @pokearu, @g-gaston @hrak is this ready for merging or need further review/testing? There was also an idea to skip and move to CAPI 1.6 ?

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[hrak]

PR updated for CAPI v1.5.8. Sorry for the delay.

[vishesh92]

Remove commented code.

[vishesh92]

@hrak there are some unresolved comments by @g-gaston. Can you please address/resolve them?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[vishesh92]

This PR has some conflicts and some comments needs to be addressed/resolved. Changing milestone for this PR to v0.6.0 for now.

[hrak]

Hi, I'm sorry I haven't been able to dedicate much time on this lately cause I'm swamped in launching our k8s product at work. I will update the PR when i have some time.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.