Merge pull request #313 from chrisdoherty4/patch/swallow-error

Stop swallowing VM deployment error
kubernetes-sigs · Sep 22, 2023 · 93841c7 · 93841c7
2 parents a2e323a + 1771844
commit 93841c7
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/cloud/instance.go b/pkg/cloud/instance.go
@@ -343,10 +343,13 @@ func (c *client) DeployVM(
 
 		csMachine.Spec.InstanceID = pointer.String(vm.Id)
 		csMachine.Status.InstanceState = vm.State
-	} else {
-		csMachine.Spec.InstanceID = pointer.String(deployVMResp.Id)
-		csMachine.Status.Status = pointer.String(metav1.StatusSuccess)
+
+		return fmt.Errorf("incomplete vm deployment (vm_id=%v): %w", vm.Id, err)
 	}
+
+	csMachine.Spec.InstanceID = pointer.String(deployVMResp.Id)
+	csMachine.Status.Status = pointer.String(metav1.StatusSuccess)
+
 	return nil
 }