Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add documentation for running wasm workloads #3161

Merged
merged 1 commit into from
Feb 17, 2023
Merged

add documentation for running wasm workloads #3161

merged 1 commit into from
Feb 17, 2023

Conversation

devigned
Copy link
Contributor

@devigned devigned commented Feb 8, 2023 •
edited
Loading

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR adds documentation for running Wasm / WASI workloads on CAPZ clusters.

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

add documentation for running WebAssembly workloads on CAPZ clusters

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

@devigned: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-ci-entrypoint
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-aks
  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-apiversion-upgrade
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-conformance
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-e2e-optional
  • /test pull-cluster-api-provider-azure-e2e-workload-upgrade
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts-serial-slow

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-ci-entrypoint
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-aks
  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-verify

In response to this:

/retest pull-cluster-api-provider-azure-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devigned
Copy link
Contributor Author

devigned commented Feb 8, 2023

/test pull-cluster-api-provider-azure-test

@devigned devigned requested review from CecileRobertMichon and removed request for marosset February 8, 2023 23:41
CecileRobertMichon
CecileRobertMichon reviewed Feb 9, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc looks good on first read but I'm going to try this out and follow the steps for my own learning

Mossaka
Mossaka approved these changes Feb 9, 2023
View reviewed changes
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
@mboersma
Copy link
Contributor

mboersma commented Feb 9, 2023

/milestone v1.8

@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Feb 9, 2023
mboersma
mboersma reviewed Feb 15, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great writing: very clear and task-focused. I had some small, mostly optional comments.

docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
@devigned
Copy link
Contributor Author

Thank you for the fantastic feedback, @mboersma, @CecileRobertMichon, and @Mossaka. The suggested changes helped a ton.

I have addressed each of them. I believe this is ready for another round of reviews when you have a minute.

mboersma
mboersma reviewed Feb 17, 2023
View reviewed changes
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
docs/book/src/topics/wasi.md Outdated Show resolved Hide resolved
CecileRobertMichon
CecileRobertMichon reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devigned
Copy link
Contributor Author

@mboersma you are my favorite editor :). You are awesome, my friend!

mboersma
mboersma approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ed6920ea02a3ff7ade260736d243ee730ff6087

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@CecileRobertMichon
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4975d24 into kubernetes-sigs:main Feb 17, 2023
@devigned devigned deleted the wasm-docs branch February 21, 2023 16:54
@dtzar dtzar mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@Mossaka Mossaka Mossaka approved these changes

@mboersma mboersma mboersma approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@devigned @k8s-ci-robot @mboersma @CecileRobertMichon @Mossaka