Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Disable dependabot for hack/* modules #335

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Nov 23, 2023

What this PR does / why we need it:
It's not necessary to update dependency for internal tools so frequently. So, it's better to disable dependabot for them, or otherwise it creates to many PRs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

It's not necessary to update dependency for internal tools so frequently.
So, it's better to disable dependabot for them, or otherwise it creates
to many PRs.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 23, 2023
@furkatgofurov7
Copy link
Member

It's not necessary to update dependency for internal tools so frequently. So, it's better to disable dependabot for them, or otherwise it creates to many PRs.

If it is just too frequent but we still need updates, we could increase the interval of updates done by the bot and keep it running, otherwise, let's remove it completely

@alexander-demicev
Copy link
Contributor

can we do monthly updates? For test package also maybe

We don't really need to update our dependencies so often. It makes
sense to run dependabot once a month, instead of each week.
@furkatgofurov7
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
Copy link
Contributor

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d775ba72046a7ec86ac0ab6bba592ca1e27dfa21

@k8s-ci-robot k8s-ci-robot merged commit e3b4abe into kubernetes-sigs:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants