Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.21.4 #648

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

nckturner
Copy link
Contributor

What this PR does / why we need it:
Update go to 1.21.4

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

@nckturner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-integration ee5a89c link true /test pull-aws-iam-authenticator-integration
pull-aws-iam-authenticator-e2e ee5a89c link true /test pull-aws-iam-authenticator-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nckturner
Copy link
Contributor Author

Weird:

�[38;5;10m•�[0mcould not get token: AccessDenied: User: arn:aws:iam::209411653980:user/dims is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::209411653980:role/aws-iam-authenticator-test-role-KubernetesAdmin
	status code: 403, request id: 65556482-81f4-4320-9d3b-2411e3362b28

Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nckturner nckturner merged commit b2b0f68 into kubernetes-sigs:master Nov 28, 2023
5 of 8 checks passed
@nckturner
Copy link
Contributor Author

Test failures should be unrelated, merged.

nckturner added a commit to nckturner/aws-iam-authenticator that referenced this pull request Dec 1, 2023
nckturner added a commit to nckturner/aws-iam-authenticator that referenced this pull request Dec 1, 2023
nckturner added a commit to nckturner/aws-iam-authenticator that referenced this pull request Dec 1, 2023
k8s-ci-robot added a commit that referenced this pull request Dec 4, 2023
nckturner added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants