Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go vunlncheck fix #646

Closed
wants to merge 4 commits into from
Closed

Go vunlncheck fix #646

wants to merge 4 commits into from

Conversation

nckturner
Copy link
Contributor

What this PR does / why we need it:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 21, 2023
nckturner
nckturner commented Nov 21, 2023
View reviewed changes
cmd/aws-iam-authenticator/server.go Outdated
@@ -52,15 +53,16 @@ var serverCmd = &cobra.Command{
var err error
fmt.Printf("Authenticator Version: %q, %q\n", pkg.Version, pkg.CommitID)
metrics.InitMetrics(prometheus.DefaultRegisterer)
stopCh := signals.SetupSignalHandler()
cmd.Context()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahhausler what are we doing with this? https://github.com/spf13/cobra/blob/main/command.go#L257-L266

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop it

pkg/mapper/configmap/configmap.go
return
default:
watcher, err := ms.configMap.Watch(context.TODO(), metav1.ListOptions{
watcher, err := ms.configMap.Watch(context.Background(), metav1.ListOptions{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahhausler originally you had this set to the same context that was passed in to startLoadConfigMap(), but this was causing the context to be closed when the watch call failed. I'm not sure what the right thing to do here is though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok good catch

@nckturner nckturner force-pushed the go-vunlncheck-fix branch 6 times, most recently from c938a74 to b6ff237 Compare November 22, 2023 04:06
@nckturner
Fix context/finish removing stopCh
baea9c0 
* Context for configmap watch needs to be created from Background(),
  otherwise watch failure will cause authenticator to crash.
* Add some logging.
* Remove unnecessary references to stopCh.
@nckturner
Copy link
Contributor Author

Need this PR for integration tests: kubernetes/test-infra#31295

@nckturner
Copy link
Contributor Author

/test pull-aws-iam-authenticator-integration

@nckturner
Copy link
Contributor Author

/retest

@nckturner
Copy link
Contributor Author

nckturner commented Nov 27, 2023 •
edited
Loading

/test pull-aws-iam-authenticator-integration

I added dind to the job config to fix the following error:

Can't connect to 'docker' daemon.  please fix and retry.

Not sure why its still failing on that error. Trying to run again, maybe needed more time to propagate the job config.

@k8s-ci-robot
Copy link
Contributor

@nckturner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-e2e baea9c0 link true /test pull-aws-iam-authenticator-e2e
pull-aws-iam-authenticator-integration baea9c0 link true /test pull-aws-iam-authenticator-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nckturner nckturner closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahhausler micahhausler micahhausler left review comments

@justinsb justinsb Awaiting requested review from justinsb

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nckturner @k8s-ci-robot @micahhausler