Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goreleaser --skip-publish flag deprecation #121

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Oct 8, 2024

  • --skip-publish was replaced with --skip=publish
  • --rm-dist was replaced with --clean

https://goreleaser.com/deprecations/#-skip
https://goreleaser.com/deprecations/#-rm-dist

This resolves the CI failure in #120

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from wongma7 and xdu31 October 8, 2024 14:41
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2024
* --skip-publish was replaced with --skip=publish
* --rm-dist was replaced with --clean

https://goreleaser.com/deprecations/#-skip
https://goreleaser.com/deprecations/#-rm-dist

Signed-off-by: Michael Shen <[email protected]>
@kmala
Copy link

kmala commented Oct 15, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kmala: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjlshen
Copy link
Contributor Author

mjlshen commented Oct 24, 2024

@xdu31 / @wongma7 Do either of you have cycles to review this?

@kmala
Copy link

kmala commented Nov 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2024
@kmala
Copy link

kmala commented Nov 1, 2024

/approve

Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala, micahhausler, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 24ffc61 into kubernetes-sigs:master Nov 12, 2024
4 of 5 checks passed
@mjlshen mjlshen deleted the goreleaser branch November 12, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants