Switch to aws-sdk-go-v2 #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mjlshen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
mjlshen
commented
Oct 8, 2024
There was a problem hiding this comment.
I tried to keep this code as similar to the original version as possible, but there are two considerations I ran into that I'm happy to implement if reviewers think they're better
- It may make more sense to use
errors.Asto filter errors instead of switching on the error code https://aws.github.io/aws-sdk-go-v2/docs/handling-errors/#api-error-responses - The
smithy.APIErrortype has anErrorFaultmethod that classifies certain errors as client/server/unknown faults https://pkg.go.dev/github.com/aws/smithy-go#ErrorFault. This could be used instead of maintaining our own list of client-fault error codes.
This was referenced Oct 8, 2024
* We have been pinning to older versions of many golangci-lint packages that are no longer needed * Updated golangci-lint to v1.61.0 and change a deprecated --deadline flag to --timeout * Resolve linter errors Signed-off-by: Michael Shen <[email protected]>
grpc.Dial and grpc.DialWithContext were deprecated and mention their replacement as grpc.NewClient. https://pkg.go.dev/google.golang.org/[email protected]#Dial One consequence of this change is that the target address needs to have "unix:" or "unix://" prepended to the absolute path for NewClient to create a connection properly. Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
Signed-off-by: Michael Shen <[email protected]>
It was providing a client-side rate limiter that is now built-in functionality in aws-sdk-go-v2 Signed-off-by: Michael Shen <[email protected]>
mjlshen
force-pushed
the
aws-sdk-go-v2
branch
from
0d0cbec to
2f5abc2
Compare
k8s-ci-robot
added
size/XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the codebase from aws-sdk-go to aws-sdk-go-v2 due to aws-sdk-go going EoL next year https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/
For the most part, it is faithful to the original code, some differences to highlight:
httputilpackage was removed from this codebase - it was providing an implementation of a client-side rate limiter that is now built-in functionality in aws-sdk-go-v2.CredentialsChainVerboseErrorsoption was removed in aws-sdk-go-v2 What happened to CredentialsChainVerboseErrors? aws/aws-sdk-go-v2#98Fixes #117