-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test - subpath pattern, repeated elements #1117
Add unit test - subpath pattern, repeated elements #1117
Conversation
Hi @seanzatzdev-amazon. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Ashley-wenyizha, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Adds new unit test.
What is this PR about? / Why do we need it?
This adds a unit test for the subpath pattern to test if repeated elements work correctly, with repeated elements referring to using elements such as the PVC name multiple times in the subpath pattern.
The reason for this unit test is to ensure storage classes which use elements such as the PVC name multiple times in their subpath pattern do not encounter any errors.
What testing is done?
Unit tests ran successfully.