Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create e2e test for subpath pattern correctness #1115

Closed
wants to merge 1 commit into from
Closed

Create e2e test for subpath pattern correctness #1115

wants to merge 1 commit into from

Conversation

seanzatzdev-amazon
Copy link
Contributor

Create e2e test for subpath pattern correctness

Is this a bug fix or adding new feature?
Adds a new e2e test.
What is this PR about? / Why do we need it?
This PR adds an e2e test to test correctness of the subpath pattern feature when creating new access points.
What testing is done?
Submitting to run against github cluster

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @seanzatzdev-amazon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seanzatzdev-amazon
Once this PR has been reviewed and has the lgtm label, please assign nckturner for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2023
@mskanth972
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2023
@seanzatzdev-amazon
Copy link
Contributor Author

/retest

1 similar comment
@seanzatzdev-amazon
Copy link
Contributor Author

/retest

@seanzatzdev-amazon
Copy link
Contributor Author

/test pull-aws-efs-csi-driver-e2e

@seanzatzdev-amazon
Copy link
Contributor Author

/retest

mskanth972
mskanth972 reviewed Aug 30, 2023
View reviewed changes
test/e2e/e2e.go Outdated
// framework.ExpectNotEqual(len(nodePods.Items), 0, "Get node pods count")
// nodePodName := nodePods.Items[0].Name
ginkgo.By("Checking if access point's directory matches expected structure") //where can i check that the directory was created??
cmd := fmt.Sprintf("cd mnt && cd %s && pwd", directoryCreated)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accesspoint mountPath will be /mnt/volume1
So check for the subdirectories inside this folder.
You can refer here

@k8s-ci-robot
Copy link
Contributor

@seanzatzdev-amazon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-e2e 5555914 link true /test pull-aws-efs-csi-driver-e2e
pull-aws-efs-csi-driver-external-test-eks 5555914 link true /test pull-aws-efs-csi-driver-external-test-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mskanth972 mskanth972 mskanth972 left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

@justinsb justinsb Awaiting requested review from justinsb

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanzatzdev-amazon @k8s-ci-robot @mskanth972