fix: multi-cluster.libsonnet to support grafana dashboard join "byField" Selector #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since, most of the selectors for the dashboard are overriden by custom variables. File in path: dashboards/resources/multi-cluster.libsonnet does have the tranformation "byField" Selector hardcoded as "cluster" but whereas all other clustername selectors use the override variable "%(clusterLabel)s". Apparently, this fork contains the change of converting hard-coded selector to over-ride selector.
danushadhitya
changed the title
|
Hi @danushadhitya, thank you for the PR. I'm seeing an interpolation issue, which could be related to how withOptions fields are parsed, could you try this ?
|
…ld" Selector with interpolation error fix
|
Thanks for the comment @n888. I have fixed it now. |
|
LGTM Local diff test with index e6bb1b71..c3333fb2 100644
--- a/charts/grafana/mixin/dashboards/k8s-resources-multicluster.json
+++ b/charts/grafana/mixin/dashboards/k8s-resources-multicluster.json
@@ -354,7 +354,7 @@
{
"id": "joinByField",
"options": {
- "byField": "cluster",
+ "byField": "k8s_cluster_name",
"mode": "outer"
}
},
@@ -542,7 +542,7 @@
{
"id": "joinByField",
"options": {
- "byField": "cluster",
+ "byField": "k8s_cluster_name",
"mode": "outer"
}
}, |
skl
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since, most of the selectors for the dashboard are overriden by custom variables.
File in path: dashboards/resources/multi-cluster.libsonnet does have the tranformation "byField" Selector hardcoded as "cluster" but whereas all other clustername selectors use the override variable "%(clusterLabel)s". This fork contains the change of converting hard-coded selector to over-ride selector which supports grafana dashboard.