fix(dashboards): Port kubelet dashboard to new grafonnet #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
changed the title
|
Looks like this CI is failling https://github.com/kubernetes-monitoring/kubernetes-mixin/actions/runs/8854904985/job/24318871025?pr=918 Other than that LGTM |
Right! Thanks for catching that.. I pushed and submitted this late on a Friday, and didn't come back to check the CI 😂 |
|
Hmmn.. Looks like it's failing jsonnet linting from previous merges now 🤔 |
|
Found the issue(s).. I fixed the linting errors for the other dashboards, as well as the grafana-builder library. See #922 for that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special note:
This includes some drive-by fixes for
jsonnet-linterrors which cropped up from previous dashboard updates.See #922 for the final fix for CI. I put that in a separate PR because it changes a file at the root of the repo (
jsonnetfile.json).Part of:
Following on from:
BEFORE
AFTER
