Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split kube_apiserver rules #892

Merged

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Feb 20, 2024

Split the kube apiserver rules into separate files. This is in order to make it easier to import different kube apiserver rules into separate PrometheusRule objects in order to target Prometheus vs Thanos Rule for evaluation.

Split the kube apiserver rules into separate files. This is in order to make it
easier to import different kube apiserver rules into separate
`PrometheusRule` objects in order to target Prometheus vs Thanos Rule
for evaluation.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/split-histogram branch from 4db07bd to 0b456ff Compare February 20, 2024 14:08
Copy link
Contributor

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for this.

Copy link
Member

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool what this enables! 🚀
Thanks for sending it along!

@metalmatze metalmatze merged commit a1c276d into kubernetes-monitoring:master Feb 27, 2024
6 checks passed
@SuperQ SuperQ deleted the superq/split-histogram branch February 28, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants