Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): use new grafonnet for apiserver dashboard #890

Merged
merged 3 commits into from
Feb 21, 2024
Merged

fix(dashboards): use new grafonnet for apiserver dashboard #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c41a486
fix(dashboards): use new grafonnet for apiserver dashboard
Duologic Feb 16, 2024
bec80ad
fix(ci): add exclusion in .lint file
Duologic Feb 16, 2024
5b498c9
fix: remove bad line
Duologic Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ exclusions:
target-instance-rule:
panel-title-description-rule:
panel-units-rule:
panel-datasource-rule:
reason: The new Grafonnet promotes the use of datasources at the query level. This should probably end up in the linter as a valid option.
Comment on lines +8 to +9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter wants that the Panel has a datasource set that matches the template variable, this is debatable. Panels do not really deal with datasources, the value at the panel level is passed through by the UI to the query targets.

When you only use one data source, this doesn't matter that much but when combining queries from multiple data sources on the same panel, then you have to set it to -- Mixed -- on the Panel level.

This is the what the new Grafonnet does, from a jsonnet/code perspective you'll see that the data source is configured on the query rather than the panel.

Loading
Loading