Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json logging format #1256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Dec 21, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Only one line of log is changed to structured logging, to prove the json format works. We can migrate others in the future.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Like: kubernetes-csi/external-resizer#330

Related:

Does this PR introduce a user-facing change?:

Add support for -logging-format=json
Remove klog specific flags according to KEP-2845

KEP-2845: Deprecate klog specific flags in Kubernetes Components

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: huww98
Once this PR has been reviewed and has the lgtm label, please assign yuxiangqian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 21, 2024
@xing-yang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2024
@xing-yang
Copy link
Collaborator

Can you replace "KEP-2845" in the release notes with a description of what that feature is about?
Also add "KEP-2845" and a link to the KEP in the PR description itself.

@huww98
Copy link
Contributor Author

huww98 commented Dec 23, 2024

Can you replace "KEP-2845" in the release notes with a description of what that feature is about?

Actually already included, that is "Remove klog specific flags". KEP-2845 is just offering more context to the interested reader of the release note. kubernetes-csi/external-resizer#411 contains some more discussion about this change.

Also add "KEP-2845" and a link to the KEP in the PR description itself.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants