-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support json logging format #1256
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: huww98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @huww98. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Can you replace "KEP-2845" in the release notes with a description of what that feature is about? |
Actually already included, that is "Remove klog specific flags". KEP-2845 is just offering more context to the interested reader of the release note. kubernetes-csi/external-resizer#411 contains some more discussion about this change.
Done |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Only one line of log is changed to structured logging, to prove the json format works. We can migrate others in the future.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Like: kubernetes-csi/external-resizer#330
Related:
Does this PR introduce a user-facing change?:
KEP-2845: Deprecate klog specific flags in Kubernetes Components