Pass context on in GroupSnapshot sync functions #1193
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
|
/assign |
| @@ -671,7 +672,7 @@ func (ctrl *csiSnapshotCommonController) groupSnapshotWorker() { | |||
| } | |||
| defer ctrl.groupSnapshotQueue.Done(keyObj) | |||
|
|
|||
| if err := ctrl.syncGroupSnapshotByKey(keyObj.(string)); err != nil { | |||
| if err := ctrl.syncGroupSnapshotByKey(context.TODO(), keyObj.(string)); err != nil { | |||
There was a problem hiding this comment.
What about using context.Background() here?
In my opinion, this is the top-level context for this request.
There was a problem hiding this comment.
Yes, I considered that as well. As you point it out too, I'll update it.
nixpanic
force-pushed
the
cleanup/context-TODO
branch
from
ba580c6
to
e4730bc
Compare
|
Tested. Works beautifully for me. /lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign xing-yang |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nixpanic, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@nixpanic: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
kind cleanup
What this PR does / why we need it:
Address a TODO comment.
Which issue(s) this PR fixes:
Updates #1171
Special notes for your reviewer:
TODO note added by @leonardoce.
The sync operations are triggered from a work queue, so there are no real contexts related to the original request. A single context is now created and passed on from the work queue function.
Does this PR introduce a user-facing change?: