Pass PVC annotations to req.Parameters when --extra-create-metadata is enabled

[vinli-cn]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adding PVC's annotation to CreateVolumeRequest.Parameters when --extra-create-metadata is enabled, fix issue #86
Which issue(s) this PR fixes:

Fixes #86

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adding PVC's annotation to CreateVolumeRequest.Parameters when --extra-create-metadata is enabled

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinli-cn
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval by writing /assign @pohly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @vinli-cn!

It looks like this is your first PR to kubernetes-csi/external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @vinli-cn. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vinli-cn]

/ok-to-test

[k8s-ci-robot]

@vinli-cn: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vinli-cn]

/assign @kubernetes-csi-reviewers

[k8s-ci-robot]

@vinli-cn: GitHub didn't allow me to assign the following users: kubernetes-csi-reviewers.

Note that only kubernetes-csi members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @kubernetes-csi-reviewers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ggriffiths]

@vinli-cn Your PR title says "pass namespace annotations", but your code is passing PVC annotations to the driver.

Passing PVC annotations to a CSI Driver request has been discussed at length in this thread:
#86

I would read up on the thread and see if you have anything else to add as to why PVC annotations should be added to the CSI create volume request.

[vinli-cn]

@vinli-cn Your PR title says "pass namespace annotations", but your code is passing PVC annotations to the driver.

Passing PVC annotations to a CSI Driver request has been discussed at length in this thread: #86

I would read up on the thread and see if you have anything else to add as to why PVC annotations should be added to the CSI create volume request.

thanks for reviewing the PR.

I updated the title and description of this PR according to issue #86, user might need to make use of the extra PVC's annotations.

Could you please review again and share your insights?

Thanks!

[ggriffiths]

Hi @vinli-cn, thank you for updating the PR description!

I think your PR title is still incorrect:

Pass namespace annotations to driver when --extra-create-metadata is enabled

Can you edit this to the below so we're clear what's being proposed?

Pass PVC annotations

Anyway, @vinli-cn, you should read up on the thread in issue #86. Many people have proposed this change in the past, but the maintainers decided to not add it.

If you think you have a compelling use case as to why this should be supported, send a message in #86. Discussion in this current pull request will not result in it being merged.

[ggriffiths]

Feel free to re-request review if this proposal is accepted in the issue I linked.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.