-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: Be more verbose if quitting early from misconfiguration #306
base: master
Are you sure you want to change the base?
Conversation
If the driver lacks support for usefully running the health monitor, be verbose by default about why we are exiting. The resulting logs will be handy in pointing the driver developer what thy might have done wrong in their CSI implementation, even if they didn't pass in a non-default --v=2. Fixes: kubernetes-csi#305 Signed-off-by: Eric Blake <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ebblake The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ebblake! |
Hi @ebblake. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
If the driver lacks support for usefully running the health monitor, be verbose by default about why we are exiting. The resulting logs will be handy in pointing the driver developer what thy might have done wrong in their CSI implementation, even if they didn't pass in a non-default --v=2.
Fixes: #305
What type of PR is this?
/kind bug
What this PR does / why we need it:
Make it easier for CSI driver developers to learn if they are using this sidecar incorrectly (for example, if the driver forgot to expose a feature this sidecar relies on).
Which issue(s) this PR fixes:
Fixes #305
Special notes for your reviewer:
Does this PR introduce a user-facing change?: