-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenApi generate from k8s 1.28 with USE_SINGLE_PARAMETER
and client-side openapi validation enabled
#2991
OpenApi generate from k8s 1.28 with USE_SINGLE_PARAMETER
and client-side openapi validation enabled
#2991
Conversation
Signed-off-by: Min Jin <[email protected]> remove JSON edition temporarily Signed-off-by: Min Jin <[email protected]> ignore JSON unit test temporarily Signed-off-by: Min Jin <[email protected]> use forked gen Signed-off-by: Min Jin <[email protected]>
Signed-off-by: Kubernetes Prow Robot <[email protected]>
de3d820
to
09f9c21
Compare
Signed-off-by: Min Jin <[email protected]> remove java8 from build action Signed-off-by: Min Jin <[email protected]>
09f9c21
to
56449d9
Compare
Signed-off-by: Min Jin <[email protected]>
5f9c000
to
06a989d
Compare
This will be a pretty disruptive change. Is there a way to have both options be feasible for a time? Otherwise people adopting this change will require some major code changes. Or maybe we can do this change in the |
@brendandburns right, for those who are not ready to onboard the new API interface, they can still use the legacy version module by adding https://github.com/kubernetes-client/java/blob/master-java8/pom.xml#L5 in the foreseeable future, we publish both from master branch and master-java8 branch together |
Sounds good. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With this PR, the generated openapi client will land a non-backward-compatible change which refactors the api interface simpler and clearer, e.g.:
Previously the API interface was like:
After enabling
USE_SINGLE_PARAMETER
, it will be: