Branch(java8): Add -legacy version qualifier to java8 compatible modules
#2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
yue9944882
added
do-not-merge/hold
k8s-ci-robot
added
size/S
yue9944882
changed the title
client-java-api module to client-java-api-legacyclient-java-api module to client-java-api-legacy
k8s-ci-robot
added
the
cncf-cla: yes
|
Suffix feels fine to me for now at least, if people complain we can always change it in future releases. |
Signed-off-by: Min Jin <[email protected]>
yue9944882
force-pushed
the
rename-java8-module
branch
from
c7c35bf to
fb59995
Compare
k8s-ci-robot
added
size/M
yue9944882
changed the title
client-java-api module to client-java-api-legacy-legacy version qualifier to java8 compatible modules
|
/hold cancel @brendandburns update the PR to add a
i suppose the new suffix conforms to the maven release version convention here: https://docs.oracle.com/middleware/1212/core/MAVEN/maven_version.htm |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brendandburns alternatively, do you think we should make these legacy java8-compatible codes a new module (specifically a new module name) or the same module name with a suffixed version e.g.
19.0.0.legacy?