Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Generate from openapi release-1.28 #2862

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 31, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: github-actions[bot]
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Min Jin <[email protected]>
@yue9944882
Copy link
Member

@brendandburns what do you think if we start a new "client-java-v2" module for the jakarta support? as far as i can see, upgrading the generator will break the following compatibilities:

  • no longer compatible with java 8
  • it will introduce a new client-side validation mechanism during gson deserialization

also by cutting a new module, we can also enable useSingleRequestParameter which will merge the openapi parameters into a single composite object which is easier for clients to upgrade in the future.

@brendandburns
Copy link
Contributor

@yue9944882 apologies, I missed this question (Github notifications don't really work for me there's too much volume)

I think moving this version to client-java-legacy and updating the main line to stop supporting java8 makes sense to me.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brendandburns
Copy link
Contributor

I think that this can be closed, right @yue9944882

@brendandburns
Copy link
Contributor

Closing this it has been replaced by #3027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants