Use Go 1.23 (#29)

Signed-off-by: 1gtm <[email protected]> Signed-off-by: Tamal Saha <[email protected]>
kubeops · Aug 17, 2024 · 2ceb2b8 · 2ceb2b8
1 parent 311d721
commit 2ceb2b8
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,13 +16,13 @@ concurrency:
 jobs:
  build:
  name: Build
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-24.04
  steps:
 
- - name: Set up Go 1.22
+ - name: Set up Go 1.23
  uses: actions/setup-go@v1
  with:
- go-version: '1.22'
+ go-version: '1.23'
  id: go
 
  - uses: actions/checkout@v2

diff --git a/.github/workflows/release-tracker.yml b/.github/workflows/release-tracker.yml
@@ -11,7 +11,7 @@ concurrency:
 
 jobs:
  build:
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-24.04
 
  steps:
  - uses: actions/checkout@v1

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,7 +13,7 @@ concurrency:
 jobs:
  build:
  name: Build
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-24.04
  steps:
  - uses: actions/checkout@v1
 

diff --git a/Makefile b/Makefile
@@ -77,9 +77,9 @@ TAG := $(VERSION)_$(OS)_$(ARCH)
 TAG_PROD := $(TAG)
 TAG_DBG := $(VERSION)-dbg_$(OS)_$(ARCH)
 
-GO_VERSION ?= 1.22
+GO_VERSION ?= 1.23
 BUILD_IMAGE ?= ghcr.io/appscode/golang-dev:$(GO_VERSION)
-CHART_TEST_IMAGE ?= quay.io/helmpack/chart-testing:v3.5.1
+CHART_TEST_IMAGE ?= quay.io/helmpack/chart-testing:v3.11.0
 
 OUTBIN = bin/$(BIN)-$(OS)-$(ARCH)
 ifeq ($(OS),windows)

diff --git a/pkg/plan/plan.go b/pkg/plan/plan.go
@@ -224,13 +224,13 @@ func SetDNSRecords(ctx context.Context, edns *api.ExternalDNS) ([]api.DNSRecord,
 
  reg, err := createRegistry(cfg, pvdr)
  if err != nil {
- klog.Errorf(err.Error())
+ klog.Errorln(err)
  return nil, err
  }
 
  dnsRecs, err := createAndApplyPlan(ctx, cfg, reg, endpointsSource)
  if err != nil {
- klog.Errorf(err.Error())
+ klog.Errorln(err)
  return nil, err
  }