doc(model-registry): Added Model Registry CSI documentation to installation and getting started sections #3922
Conversation
|
Hi @Al-Pragliola. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Alessio Pragliola <[email protected]>
Al-Pragliola
force-pushed
the
feat/add-csi-to-mr-section
branch
from
51df5b4
to
d5f06fa
Compare
There was a problem hiding this comment.
Thanks a lot @Al-Pragliola ! couple of early comment but overall lgtm
| "iris", | ||
| "gs://kfserving-examples/models/sklearn/1.0/model", |
There was a problem hiding this comment.
Does this require login access to download?
If so, I would use one of the model.joblib I've used in another demo with link to github
There was a problem hiding this comment.
no, at the time of writing no authorization is required to fetch the model with kserve, it's a public bucket.
It's also the model used in kserve's getting started guide, so I think it's pretty safe to keep it there.
| If you want Kserve to be able to support `model-registry://` URI formats, you must apply the cluster-scoped `CustomStorageContainer` CR. | ||
|
|
||
| ```shell | ||
| kubectl apply -k "https://github.com/kubeflow/model-registry/manifests/kustomize/options/csi?ref=main" |
There was a problem hiding this comment.
We can hold this PR until we have v0.2.10 including this manifest imho
There was a problem hiding this comment.
Fine by me, I'll update the versions to 0.2.10 when it's available on the other manifest links too.
Signed-off-by: Alessio Pragliola <[email protected]>
There was a problem hiding this comment.
/lgtm
thanks @Al-Pragliola couple minor addendum for your considerations?
Co-authored-by: Matteo Mortari <[email protected]> Signed-off-by: Alessio Pragliola <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Now that CSI manifests have been added to the Model Registry manifests folder, this update includes comprehensive documentation on the installation and getting started process for deploying models using the Kserve CustomStorageContainer CR and Model Registry CSI. I also changed the example from mnist to scikit-learn and generally bumped the model registry version.
This PR supersedes PR #3846