Adding support for cert-manager certificates to manage webhook TLS. #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dskatz This change would be helpful to the stability of the operator, the operator breaks from time to time after the cleanup job. any reason for not merging? |
|
We need this, any update on merging this? |
|
@dskatz Could you resolve the merge conflicts? |
|
I opened my own fork and cloned this PR trying to resolve the merge conflicts: #2079 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Was this effectively handled as part of the big rewrite? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can resolve: #1178
This adds the option for the mutation webhook TLS Certificate management to be done by cert-manager.
webhook-init-jobandwebhook-cleanup-jobare disabled, since it will be unnecessary to generate certificates adhoc.Open to suggestions on adjustment of the
valuesinterface and configuration.