fix(ws): use correct nodeSelector type and add CRD validation tests
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Signed-off-by: Mathew Wicks <[email protected]>
|
@jiridanek this should be a simple review so we can unblock the reconciliation work by @Adembc (mainly the issue he had was related to the type of |
jiridanek
approved these changes
Jul 5, 2024
|
/lgtm @thesuperzapper sorry about the approve; our (@openshift's) instance of prow understands github approve as a lgtm; guess different configuration |
|
/approve @Adembc don't forget to rebase your PR on |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to the workspace controller:
spec.podTemplate.options.podConfig.values[].spec.nodeSelectorspecofpodConfigandimageConfigvalues does not change+listType:="map"because they should not support multiple elements with the same key:spec.podTemplate.volumes.data[](keyed onname)spec.podTemplate.extraEnv[](keyed onname)I have also added tests for some of the more complicated
+kubebuilder:validation:XValidation/x-kubernetes-validationswe are doing, so we dont have to worry about regressions in the future.