Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 'printf: non-constant format string in call to fmt.Errorf (govet)' lint errors #666

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tenzen-y
Copy link
Member

I fixed lint errors as we can see in https://github.com/kubeflow/mpi-operator/actions/runs/11353824606/job/31579702079, and I removed the --new-from-rev=origin/master option from golangci-lint so that we can avoid the master branch error.

pkg/controller/mpi_job_controller.go:886:26: printf: non-constant format string in call to fmt.Errorf (govet)
                return nil, fmt.Errorf(msg)
                                       ^

@tenzen-y
Copy link
Member Author

/assign @alculquicondor @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Oct 16, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit c738a83 into kubeflow:master Oct 16, 2024
10 checks passed
@tenzen-y tenzen-y deleted the fix-lint-error branch October 16, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants