Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obviously specify the supported platforms in Makefile #663

Merged
merged 1 commit into from
Oct 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,11 @@ jobs:
with:
go-version-file: go.mod
- name: Run tests
run: make RELEASE_VERSION=test CONTROLLER_VERSION=v2 TEST_KIND_IMAGE=kindest/node:${{ matrix.kubernetes-version }} test_e2e
env:
RELEASE_VERSION: test
CONTROLLER_VERSION: v2
TEST_KIND_IMAGE: kindest/node:${{ matrix.kubernetes-version }}
PLATFORMS: linux/amd64
INTEL_PLATFORMS: linux/amd64
MPICH_PLATFORMS: linux/amd64
run: make test_e2e
5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,15 @@

BIN_DIR=_output/cmd/bin
REPO_PATH="github.com/kubeflow/mpi-operator"
REL_OSARCH="linux/amd64"
GitSHA=$(shell git rev-parse HEAD)
Date=$(shell date "+%Y-%m-%d %H:%M:%S")
RELEASE_VERSION?=v0.5.0
CONTROLLER_VERSION?=v2
BASE_IMAGE_SSH_PORT?=2222
IMG_BUILDER=docker
PLATFORMS ?= linux/amd64
PLATFORMS ?= linux/amd64,linux/arm64,linux/ppc64le
INTEL_PLATFORMS ?= linux/amd64
MPICH_PLATFORMS ?= linux/amd64
MPICH_PLATFORMS ?= linux/amd64,linux/arm64
LD_FLAGS_V2=" \
-X '${REPO_PATH}/pkg/version.GitSHA=${GitSHA}' \
-X '${REPO_PATH}/pkg/version.Built=${Date}' \
Expand Down
Loading