-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace original pointer methods with ptr libs #635
Replace original pointer methods with ptr libs #635
Conversation
/hold |
dabf607
to
a2f6c44
Compare
I think this just needs rebase |
a2f6c44
to
3c2b957
Compare
@alculquicondor I rebased this PR. |
/hold cancel |
return &v | ||
} | ||
|
||
func NewCleanPodPolicy(policy CleanPodPolicy) *CleanPodPolicy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💣
RunPolicy: kubeflow.RunPolicy{ | ||
CleanPodPolicy: kubeflow.NewCleanPodPolicy(kubeflow.CleanPodPolicyRunning), | ||
CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), | |
CleanPodPolicy: ptr.To(kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for others below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
RunPolicy: kubeflow.RunPolicy{ | ||
CleanPodPolicy: kubeflow.NewCleanPodPolicy(kubeflow.CleanPodPolicyRunning), | ||
CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CleanPodPolicy: ptr.To[kubeflow.CleanPodPolicy](kubeflow.CleanPodPolicyRunning), | |
CleanPodPolicy: ptr.To(kubeflow.CleanPodPolicyRunning), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Yuki Iwai <[email protected]>
3c2b957
to
9380457
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I replaced the original pointer methods with ptr libs.