Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce resource multiplication #634

Merged

Conversation

tenzen-y
Copy link
Member

I introduced the new Quantity multiplication method: kubernetes/kubernetes#117411
/hold
until #633 is merged.

@alculquicondor
Copy link
Collaborator

Please rebase

@tenzen-y tenzen-y force-pushed the introduce-resource-multiplication branch from e092ae9 to 604e5ec Compare April 17, 2024 18:16
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Apr 17, 2024
@tenzen-y tenzen-y force-pushed the introduce-resource-multiplication branch from 604e5ec to 4d45fe8 Compare April 17, 2024 18:52
@google-oss-prow google-oss-prow bot added size/S and removed size/XXL labels Apr 17, 2024
@tenzen-y
Copy link
Member Author

Please rebase

@alculquicondor Rebased.
/hold cancel

@alculquicondor
Copy link
Collaborator

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8d806df into kubeflow:master Apr 17, 2024
10 checks passed
@tenzen-y tenzen-y deleted the introduce-resource-multiplication branch April 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants